Explanation of Change

In the PR I:

• change design of single and multi choice lists to have radio buttons and checkboxes
• remove active state, so chosen element is not hovered anymore

The idea is to enhanced consistency among lists with selection.

Fixed Issues

$ #74938
PROPOSAL:

Tests

same as qa tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

Single selection list

For each of the following pages verify:

• item has a radio style checkmark on the right hand side
• Radio checkmark has dimensions of 20*20px
• Initially selected item has radio checkmark selected
• initially selected item does not have any background highlight
• Verify each item which is not disabled is highlighted on mouse hover and the mouse cursor is of pointer style.

Reports

• Filters > type = expense
  • Filters > type
  • Filters > action
  • Filters > approved
  • Filters > billable
  • Filters > date
  • Filters > exported
  • Filters > paid
  • Filters > posted
  • Filters > reimbursable
  • Filters > submitted
  • Filters > withdrawal type
  • Filters > withdrawn

Workspace

• Overview

  • default currency
  • company address > country
  • company address > state (select country = US to see this option)
  • more > transfer owner > currency

• Members

  • member > role

• Reports

  • add field > type
  • add field > initial value (only for type = list)

• Accounting - QBO

  • import > classes > displayed as
  • import > customers/projects > displayed as
  • import > locations > displayed as
  • export > preferred exporter
  • export > export out-of-pocket expenses as > export as
  • export > export out-of-pocket expenses as > account
  • export > export company card expenses as > export as
  • export > export company card expenses as > account
  • export > export company card expenses as > default vendor
  • card reconciliation > reconciliation account

-Accounting - QBD

• import > classes > displayed as

• import > customers/projects > displayed as

• export > preferred exporter

• export > export date

• export > export out-of-pocket expenses as > export as

• export > export out-of-pocket expense as > account

• export > export invoices to

• export > export company card expenses as > export as

• export > export company card expenses as > credit card account

• Accounting - Xero

  • xero organization
  • import > tracking categories > all map xero [...] to options
  • export > preferred exporter
  • export > purchase bill date
  • export > purchase bill status
  • export > xero bank account
  • card reconciliation > reconciliation account
  • advanced > auto sync > when to export
  • advanced > xero bill payment account
  • advanced > xero invoice collection account

• Accounting - NetSuite

  • subsidiary
  • import > departments
  • import > classes
  • import > locations
  • import > customers/projects > toggle either of the options > display as
  • import > custom segment/records > add custom segment record > do you want to add a custom segment or a custom record - page
  • import > custom segment/records > add custom segment record > ... > How should this custom record be displayed in Expensify - page
  • import > custom segment/records > item > displayed as
  • import > custom lists > add custom list > name
  • import > custom lists > add custom list > ... > How should this custom list be displayed in Expensify - page
  • import > custom lists > item > displayed as
  • export > preferred exporter
  • export > export date
  • export > export out-of pocket expenses as > export as
  • export > export company card expense as > export as
  • export > export company card expense as > default vendor
  • export > export invoices to
  • export > invoice item
  • export > invoice item = select existing > invoice item
  • export > journal entries tax posting account
  • card reconciliation > reconciliation account
  • advanced > auto-sync > when to export
  • advanced > reimbursement account
  • advanced > collection account
  • advanced > expense report approval level
  • advanced > vendor bill approval level
  • advanced > A/P approval level

• Accounting - Sage Intacct

  • entity
  • import > departments > displayed as
  • import > classes > displayed as
  • import > locations > displayed as
  • import > customers > displayed as
  • import > projects (jobs) > displayed as
  • import > user-defined dimensions > add user-defined dimension
  • import > item
  • export > preferred exporter
  • export > export date
  • export > export out-of pocket expenses as > export as
  • export > export out-of pocket expenses as > default vendor
  • export > export company card expense as > export as
  • export > export company card expense as > credit card account
  • export > export company card expense as > default vendor
  • card reconciliation > reconciliation account
  • advanced > auto-sync > when to export
  • advanced > sage intacct payment account

• Categories

  • more > settings > all default category options
  • category > approver
  • category > default tax rate
  • category > flag amount over > type
  • category > require receipts over

• Tags

• tag > approver

• Taxes

  • more > settings > workspace currency default
  • more > settings > foreign currency default

• Workflows

  • submission frequency (enable delay submissions toggle to see this option)
  • workflow > approver (enable add approvals toggle to see this option)
  • workflow > additional approver
  • payer (enable make or track payments toggle and add a bank account to see this option)

• Rules

  • cash expense default
  • billable default

• Distance rates

  • settings > unit
  • settings > default category

• Expensify cards

  • issue card > who needs a card
  • issue card > choose a limit
  • more > settlement account
  • more > settlement frequency
  • card > limit type

• Company cards

  • add cards > country
  • add cards > select feed type step
  • add cards > select feed type step( select direct feed) > who's your bank
  • add cards > select feed type step( select commercial feed) > who's your card provider
  • card > [accounting software name] credit card export
  • select cards feed
  • settings > settlement close date
  • settings > settlement close date = custom day of month > custom close date
  • assign card > who needs a card
  • assign card > choose a card
  • assign card > choose a transaction start date

• Per diem

  • more > settings > default category
  • rate > currency

Account

• Profile

  • status > clear after
  • status > vacation delegate
  • pronounce
  • timezone
  • date of birth > year
  • address > country
  • address > state ( select country = US to see this option)

• Subscription

  • add payment card > currency
  • request early cancellation
  • subscription settings > disable auto renew

• Wallet

  • add bank account > country
  • add bank account > country (select any other than US) > currency

• Expense rules

  • new rule > category
  • new rules > tag
  • new rule > tax
  • new tule > reimbursable
  • new rule > billable

• Preferences

  • priority mode
  • language
  • payment currency
  • theme

• Security

  • add copilot > select copilot
  • add copilot > access level
  • copilot > three dot menu > change access level

FAB

• Create expense

  • manual > currency
  • manual > enter amount > choose recipient
  • manual > confirmation page > category
  • manual > confirmation page > date > year
  • manual > confirmation page > tag
  • manual > confirmation page > tax
  • manual > confirmation page > report
  • distance > confirmation page > rate
  • per diem > country
  • per diem > select country > add time > sub-rate

• Create report > choose workspace

• Start chat

  • room > workspace
  • room > who can post
  • room > visibility

Chat

-Tracked expense

• submit to someone > choose recipient

• Workspace expense

  • expense item > report field (workspace should have at least one list type report field)
  • expense item > category
  • expense item > tag
  • expense item > tax
  • expense item > report
  • expense item > rate (for distance expense item only)
  • expense report > more > change workspace
  • expense report > more > change approver (only workspace admins and owner could see this option)

• create task > assignee

• task > assignee

• room chat

  • Room chat > details > settings > notify me about new messages
  • details > settings > who can post
  • details > settings > visibility

Onboarding

• track and budget expenses > name > create workspace > default currency
• manage my team > how many employees do you have?
• manage my team > 1-10 > do you use any accounting software

Multi selection

For each of the following pages verify:

• Item has a checkbox style checkmark on the right hand side
• The checkmark has dimensions of 20*20px
• Initially selected items has checkmark selected
• Initially selected items does not have any background highlight
• Verify each item which is not disabled is highlighted on mouse hover and the mouse cursor is of pointer style.

Reports

• Filters > type = expense

  • Filters > from
  • Filters > has
  • Filters > status
  • Filters > to
  • Filters > workspace
  • Filters > card
  • Filters > category
  • Filters > currency
  • Filters > expense type
  • Filters > purchase currency
  • Filters > tag
  • Filters > tax rate

• Filters > type = chat

  • Filters > in
  • filters > is

• Filters > type = task

  • Filters > assignee

Workspace

• Overview

  • more > invite

• Members

  • invite member

• Workflows

  • workflow > expense from

FAB

• Create expense
  • manual > confirmation page > Attendees

Onboarding

• track and budget expenses > name > create workspace > continue > invite members

New chat item

1. Go to FAB -> Start chat
2. Verify items has add to group button on right hand side
3. Select a few item by clicking add to group icon on each item
4. Verify selected items has square style checkmark on the right hand side and the checkmark is selected and checkmark has dimensions of 20*20px
5. Verify each item which is not disabled is highlighted on mouse hover and the mouse cursor is of pointer style
6. Click next
7. Verify each item in members sections(except the owner) has square style checkmark on right hand side and the checkmark is selected and checkmark has dimensions of 20*20px
8. Verify each item which is not disabled is highlighted on mouse hover and the mouse cursor is of pointer style

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos